HomePhabricator

False references should fall back to hash change
d076963b63adUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

False references should fall back to hash change

If a reference doesn't exist e.g. ReferenceGateway::getReference
returns false then hide the drawer and update the hash fragment

Additional changes:

  • showReference now returns a deferred object
  • getReference now rejects if no reference is found

Bug: T154861
Change-Id: I7434d9b0bcdbdc7a076db5127ed62866019ce99b

Details

Provenance
JdlrobsonAuthored on May 8 2017, 4:14 PM
ChangeId
I7434d9b0bcdbdc7a076db5127ed62866019ce99b

Commit No Longer Exists

This commit no longer exists in the repository.