HomePhabricator

First attempt implementing rewriting rules on the DOM

Authored by ssastry.

Description

First attempt implementing rewriting rules on the DOM

  • This is implemented as a post-processing pass.
  • Might require additional checks to verify rewriteability.
  • Implemented as a pair-wise tag DOM minimization strategy, i.e. it takes tag pairs (B, I) for ex, and attempts to normalize the tree just for those tag pairs. Normalizing across multiple tags is implemented as pairwise rewriting across all pairs: Ex:(b,i), (b,u),(i,u) for (b,i,u)
  • Copied over attributes as part of rewriting, but some of the attributes lose their meaning on rewriting since tags are reordered (ex: sourcePosn, sourceTagPosn). How do we handle this?

Output examples and possible issues to fix:

<i><b><u>biu</u></b></i><b><u>bu</u></b><u>u</u>

gets rewritten to:

<u><b><i>biu</i>bu</b>u</u>

But, the equivalent wikitext form:

'''''<u>biu</u>''''''''<u>bu</u>'''<u>u</u>

does not get rewritten because of parsing differences.
This wikitext gets parsed into:

<i><b><u>biu</u>'''</b></i><u>bu<b>u</b></u>

The extra ''' token in the middle thwarts DOM rewriting.

However, a slightly different version:

"'''''<u>biu</u>''<u>bu</u>'''<u>u</u>"

gets properly normalized to:

<u>'''''biu''bu'''u</u>

An alternative, but fun strategy to play with is to use the following
two normalization primitives: S(wap) and M(erge).

  • S rewrites T1(T2(x)) into T2(T1(x)) (ex: <b><i>foo</i></b> ==> <i><b>foo</b></i>)
  • M rewrites (T(x),T(y)) into (T(x,y)). (ex: <b>foo</b><b>bar</b> ==> <b>foobar</b>)

The current rewriting strategy could possibly be re-implemented as S-M
rewriting. The problem to solve there would be to find an efficient
rewriting strategy that is guaranteed to lead to a normal form. I may
not play with it now, but just documenting it for later (to play with
in my spare time).

This commit is just as a record of fun/experimental code where I get to
learn details of JS, wikitext, parsing, and DOM manipulation. Next
version of this code will attempt to introduce minimal DOM restructuring
across multiple tags at once which can be more efficient.

gwicke: Removed now passing test from whitelist, and updated another whitelist
entry which is now improved.

Change-Id: Ie97bcb164eb62c34ba61aa76ba2f4c232aa713d8

Details

Committed
GWickeMay 29 2012, 6:17 AM
Parents
rEPARb2adee0ae767: Basic rt support for indent pre variant
Branches
Unknown
Tags
Unknown
ChangeId
Ie97bcb164eb62c34ba61aa76ba2f4c232aa713d8