HomePhabricator

Make the Datetimepicker and Datepicker use OOUI
Concern Raised135d26f0b8b2

Authored by AmrEl-Absy on Jun 23 2020, 4:39 PM.

Description

Make the Datetimepicker and Datepicker use OOUI

The inputs "datetimepicker" and "datepicker" used to use
jQuery UI, which is deprecated. So they are now calling the OOUI
widgets.
There is a difference in the format of the date, which is handled
in the function getConvertedFormat().
Most parameters also have a differnce in the format or their names,
and they get handled in the function getOptions().

Bug: T248505
Change-Id: I86cdf968daf8daf0a0698536ef47f993f23cc9d4

Details

Auditors
FO-nTTaX
Committed
Yaron_KorenAug 24 2020, 4:36 PM
Parents
rEPFM2655d9c0ccf8: Localisation updates from https://translatewiki.net.
Branches
Unknown
Tags
Unknown
ChangeId
I86cdf968daf8daf0a0698536ef47f993f23cc9d4

Event Timeline

FO-nTTaX raised a concern with this commit.EditedSep 18 2020, 2:42 PM
FO-nTTaX added a subscriber: FO-nTTaX.

This change has broken compatibility with MediaWiki 1.31

[82208d4b3c9721c73b0185b9] /smash/Special:RunQuery/Match_history OOUI\Exception from line 31 of /path/to/wiki/vendor/oojs/oojs-ui/php/Theme.php: OOUI\Theme::singleton was called with no singleton theme set.

Backtrace:

#0 /path/to/wiki/vendor/oojs/oojs-ui/php/Element.php(241): OOUI\Theme::singleton()
#1 /path/to/wiki/extensions/PageForms/includes/forminputs/PF_DatePickerInput.php(108): OOUI\Element->toString()
#2 /path/to/wiki/extensions/PageForms/includes/PF_FormPrinter.php(1876): PFDatePickerInput->getHtmlText()
#3 /path/to/wiki/extensions/PageForms/includes/PF_FormPrinter.php(1270): PFFormPrinter->formFieldHTML(PFFormField, NULL)
#4 /path/to/wiki/includes/StubObject.php(112): PFFormPrinter->formHTML(string, boolean, boolean, integer, NULL, NULL, NULL, boolean, boolean)
#5 /path/to/wiki/includes/StubObject.php(138): StubObject->_call(string, array)
#6 /path/to/wiki/extensions/PageForms/specials/PF_RunQuery.php(79): StubObject->__call(string, array)
#7 /path/to/wiki/extensions/PageForms/specials/PF_RunQuery.php(26): PFRunQuery->printPage(string, boolean)
#8 /path/to/wiki/includes/specialpage/SpecialPage.php(565): PFRunQuery->execute(string)
#9 /path/to/wiki/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(string)
#10 /path/to/wiki/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#11 /path/to/wiki/includes/MediaWiki.php(863): MediaWiki->performRequest()
#12 /path/to/wiki/includes/MediaWiki.php(524): MediaWiki->main()
#13 /path/to/wiki/index.php(42): MediaWiki->run()
#14 {main}

This is the form I'm getting this error for: https://liquipedia.net/smash/index.php?title=Form:Match_history&action=edit

This commit now has outstanding concerns.Sep 18 2020, 2:42 PM