HomePhabricator

Update patch set 2
5f83cd2c99f0Unpublished

Authored by Yaron_Koren on Mar 11 2018, 3:47 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 2

Patch Set 2:

Wow, this looks great! Although I don't think a new hidden input is the best way to store this data on the page, because it won't work if there's more than one map in the form. Better would be one or more additional attributes on an existing part of the map input - the attribute name(s) should start with "data-". (https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/data-*)

Patch-set: 2
Label: Code-Review=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Mar 11 2018, 3:47 PM
Parents
rEPFMbcd2030890ad: Update patch set 2
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEPFM5f83cd2c99f0: Update patch set 2 (authored by Yaron_Koren).Mar 11 2018, 3:47 PM

Empty Commit

This commit is empty and does not affect any paths.