Update patch set 1

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.


Update patch set 1

Patch Set 1:

This makes sense. But shouldn't $formHtmlHasRun be initialized to

> false somewhere?

Yeah, you are right. And you already took care of this :)
l 882 // Flag to keep track of formHTML() runs.
l 883 $formHtmlHasRun = false;

This was already in the code, albeit unused. Looks like you originally had the same idea, so I took credit for it ;)

Patch-set: 1
Reviewer: Oetterer <2791@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0


OettererAuthored on Jul 31 2017, 4:54 AM
Gerrit Code Review <gerrit@wikimedia.org>Committed on Jul 31 2017, 4:54 AM

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEPFM9ed3525bf8df: Update patch set 1 (authored by Oetterer).Jul 31 2017, 4:54 AM

Empty Commit

This commit is empty and does not affect any paths.