HomePhabricator

Merge mw.popups.experiment into mw.popups.core

Authored by phuedx on Sep 21 2016, 1:04 PM.

Description

Merge mw.popups.experiment into mw.popups.core

ext.popups.experiment depends on .core as it initialized the mw.popups
namespace and .core depends on .experiments for
mw.popups#getEnabledState.

By merging the experiment module into core, we can eliminate any
circular dependencies.

Changes:

  • Move ext.popups.experiment.js code into ext.popups.core.js
  • Remove mw.popups.experiment module and any references to it

Note: ext.popups.experiment.test.js was left in its own file for cleaner
QUnit module setups and easier removal later. I'm not entirely happy
with doing it this way, but I'm not sure changing the mw.config within
the mw.popups.core QUnit module is worth merging the files.

Bug: T146035
Change-Id: I1f024567010acaa61c1d613c6e59c998198a5976

Details

Committed
jhobsSep 21 2016, 8:43 PM
Parents
rEPOP8f001ee4bd4b: Respect beta feature flag for logged in users
Branches
Unknown
Tags
Unknown
References
refs/changes/77/311977/4
ChangeId
I1f024567010acaa61c1d613c6e59c998198a5976