HomePhabricator

Hygiene: Improve code quality by reaching 100% coverage
4958e40c5ce5Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Hygiene: Improve code quality by reaching 100% coverage

Changes:

  • added missing unit tests
  • introduced PopupsContextTestWrapper, removed all unit-tests logic from Hooks/Context classes
  • removed getModule() from Popups.hooks.php, it's hooks responsibility to keep single context instance
  • removed class_exists calls, use ExtensionRegistry instead
  • pass ExtensionRegistry as a dependency so it's easy to mock
  • reach 100% code coverage
  • introduce PoupsContext::isBetaOn() as it was used in many places

Change-Id: Id014efe72edf24628539c76968e53eb3e06709f4

Details

Provenance
polishdeveloperAuthored on Dec 20 2016, 9:54 PM
Parents
rEPOP959bf40d9bdb: Implement necessary wiring for preferences
Branches
Unknown
Tags
Unknown
References
refs/changes/26/328426/3
ChangeId
Id014efe72edf24628539c76968e53eb3e06709f4