HomePhabricator

reducers: Make LINK_CLICK finalize but not close

Description

reducers: Make LINK_CLICK finalize but not close

... the interaction.

Following on from Iccba3c4c, LINK_CLICK shouldn't be considered the end
of an interaction because the link or preview can still be abandoned by
the user. Unlike ABANDON_END and LINK_DWELL, therefore, LINK_CLICK
musn't destroy the interaction but indicate that no more events should
be enqueued for the interaction.

More concretely, if the user has clicked the link or the preview, then
a "dwelledButAbandoned" or "dismissed" event shouldn't be logged.

Changes:

  • Distinguish between "finalizing" and "closing" an interaction, where the latter is the current behavior of ABANDON_END, LINK_DWELL, and LINK_CLICK, in the eventLogging reducer and associated tests.
  • If the interaction is finalized, then either the "dwelledButAbandoned" or "dismissed" events shouldn't be logged.

Bug: T162924
Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6

Details

Provenance
phuedxAuthored on Apr 15 2017, 11:18 AM
JdlrobsonCommitted on Apr 17 2017, 10:06 PM
Parents
rEPOP9590284c70a8: Sanitize gadget name
Branches
Unknown
Tags
Unknown
References
refs/changes/21/348321/4
ChangeId
I09d8776da992053f89a77508e29a7cde3cfeeac6