HomePhabricator

Security improvements

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Security improvements

ExternalSurvey.js

  • Parse messages used directly in HTML

SurveyFactory.php

  • Validate https for external survey link

utils.js

  • Extract a country code from the GeoIP cookie and return if
    • it is less than 3 characters in length per ISO_3166-1.
    • Otherwise, returns Unknown.

en.json

  • Update example external so it validates

Bug: T110662
Change-Id: I742221107e5becc784b2721b4df070d8cccbffe9

Details

Provenance
rmoenAuthored on Sep 21 2015, 9:25 PM
ChangeId
I742221107e5becc784b2721b4df070d8cccbffe9

Commit No Longer Exists

This commit no longer exists in the repository.