HomePhabricator

Update patch set 7
9c3d1ac25e56Unpublished

Authored by jhobs on Nov 30 2015, 5:23 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 7

Patch Set 7: Code-Review+1

@phuedx
Whoops, didn't notice it got removed from the comment on Survey.php; sorry for making this hang for so long.

@bmansurov
I think there are plenty of surveys that make sense to run on both platforms (for instance, we just ran a multiple-choice one on both). It could be argued that it's always useful to know which platform the user answered the survey from, but that should be handled in our data collection then; it should not gate our survey configs. (IMHO)

Patch-set: 7
Reviewer: Jhobs <1948@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Code-Review=+1

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Nov 30 2015, 5:23 PM
Parents
rEQS7be25f7ca678: Update patch set 7
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEQS9c3d1ac25e56: Update patch set 7 (authored by jhobs).Nov 30 2015, 5:23 PM

Empty Commit

This commit is empty and does not affect any paths.