HomePhabricator

Update patch set 4
b246767cd84cUnpublished

Authored by jhobs on Nov 23 2015, 3:26 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 4

Patch Set 4: Code-Review-1

(15 comments)

Little bit of everything. Some questions, some minors, some majors (but don't worry, I do see the "WIP"!). One of the bigger concerns is that I don't think we should be avoiding an additional constructor parameter. There's no reason to avoid it AFAICT and it's putting code in illogical places.

Patch-set: 4
Label: Code-Review=-1

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Nov 23 2015, 3:26 PM
Parents
rEQS2cddfe978d73: Update patch set 4
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEQSb246767cd84c: Update patch set 4 (authored by jhobs).Nov 23 2015, 3:26 PM