HomePhabricator

Fixes to code to support Timeless and Monobook

Description

Fixes to code to support Timeless and Monobook

Why:

  • The ReportIncident dialog works with Timeless and Monobook out of the box, but a few changes are needed to properly support these skins.
  • When users test for the MTP they need to be able to use these skins if they prefer and also be able to effectively test the tool.

What:

  • The Timeless skin doesn't seem to have a sitenotice div, so add the success banner to the top of the content area.
  • Fieldsets in Timeless have an added margin which messes with the blank space above the form fields. Removing this makes the spacing more reasonable.
  • The Monobook skin uses a different font size, which means that the em measurements for the reporting dialog make the maximum width for the dialog too small for desktop devices. Increasing the maximum width to compensate for the smaller font size makes the dialog width more reasonable.
  • The checkbox label does not align properly with the checkbox icon in the Monobook skin, so increase the padding to the left and top to properly align the label text.

Bug: T350693
Change-Id: I97f4d722f672f5524e9af0df38e3e56e91b41692

Details

Provenance
Dreamy Jazz <wbrown-ctr@wikimedia.org>Authored on Nov 7 2023, 3:04 PM
Dreamy_JazzCommitted on Nov 7 2023, 3:40 PM
Parents
rEREIe47a4f1f2e66: ReportIncidentController: Allow wildcard for all skins
Branches
Unknown
Tags
Unknown
References
refs/changes/92/972392/7
ChangeId
I97f4d722f672f5524e9af0df38e3e56e91b41692