HomePhabricator

Use cookie to dismiss help dialog and fix failing browser tests
cb26b4aa3761Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Use cookie to dismiss help dialog and fix failing browser tests

I have seen this failing:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium-jessie/9255/console

The idea is to pre-set this cookie so the help dialog never shows up
in the first place. The tests do not need to look for the element, click
it, wait for the dialog to close. This should even speed up the browser
tests, I believe.

Also this adjustes waiting conditions in several places to address
timing issues with failing browser tests.

Since these tests should be replaced by Node.js on the long run I
added "sleep" in the cases although it's not recommended.

Change-Id: Ida381faa390aa62ebaadd3713864676be80abd51

Details

Provenance
thiemowmdeAuthored on Jun 29 2018, 7:49 AM
WMDE-FischCommitted on Jul 2 2018, 3:31 PM
Parents
rERSL0fadc052651e: Merge "Remove default "return true" from hook handlers"
Branches
Unknown
Tags
Unknown
ChangeId
Ida381faa390aa62ebaadd3713864676be80abd51