HomePhabricator

Auto-scroll editor to foreign change
93c56d591a5cUnpublished

Authored by WMDE-Fisch on Jan 19 2017, 5:40 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Auto-scroll editor to foreign change

When loading the editor for the first time a base
scroll offset is calculated for each foreign diff
change and saved within the diff element.

These offset values are refreshed when the window
resizes and therefore the offset changes.

To calculate that offset a hidden editor is build
that is layouted like the actual textarea but can
provide marked up text.

When loading the conflict page for the first time,
the editor scrolls to the first foreign change.

When clicking on a foreign change the scroll offset
is used to scroll the editor to the corresponding
position.

Bug: T144608
Change-Id: Ie4d2d932ea72a667c20873f02064839e0ca0e393

Details

Committed
WMDE-FischJan 25 2017, 5:14 PM
Parents
rESCC98f2ca73263b: build: Re-use MessageDirs in banana conf
Branches
Unknown
Tags
Unknown
References
refs/changes/26/333026/4
ChangeId
Ie4d2d932ea72a667c20873f02064839e0ca0e393