HomePhabricator

Improve diff quality to match TableDiffFormatter
9c99dfe51ac1Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Improve diff quality to match TableDiffFormatter

When the custom diff formater was introduced first. A few issues appeared when there
are many changes in the same paragraph. An threshold was implemented to handle these
multiple changes as if the whole paragraph was removed and added again.

While revisiting the code now and checking the diff results on the two column conflict
page it became obvious, that this threshold is in most cases making things worse.

With this patch the threshold is removed and resulting diffs look way better now and
match the original TableDiffFormater output.

Bug: T161784
Change-Id: I51ce7eb37ac4a695f894533166ffca04d4d2d1e7

Details

Provenance
WMDE-FischAuthored on Apr 11 2017, 11:06 AM
Parents
rESCC1666a198285f: Localisation updates from https://translatewiki.net.
Branches
Unknown
Tags
Unknown
References
refs/changes/89/347589/1
ChangeId
I51ce7eb37ac4a695f894533166ffca04d4d2d1e7