HomePhabricator

Allow HtmlSplitConflictHeader to work without a latest revision
9f722562f862Unpublished

Authored by thiemowmde on Apr 29 2019, 10:46 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Allow HtmlSplitConflictHeader to work without a latest revision

  • HtmlSplitConflictHeader now requires a LinkTarget instead if a revision. This is a much smaller footprint.
  • HtmlSplitConflictHeader now accepts a revision *only* for testing. Otherwise the latest revision is loaded from the database.
  • I moved the code that called WikiPage::factory() and loads the current revision.
  • The private getLatestRevision() method is not intentionally untested, because all tests provide a fake revision.

Bug: T219727
Change-Id: Ie88bfbbfae41e006e398f636d64d85e6d61f1431

Details