Add option to use `-dsafe` argument in Lilypond command

Authored by Ebe123 on Aug 5 2017, 5:10 AM.

Description

Add option to use -dsafe argument in Lilypond command

This change makes the -dsafe argument from the Lilypond command
optional, to be disabled through the use of $wgScoreSafeMode. As now it
can be disabled, the README recommends the use of a jail/Firejail
before doing so. This change would allow Lilypond to be more flexible,
including the use of variables, and more customizations to the score,
while preventing the execution of malicious code

This change resolves T171372 and its subtasks, even though the subtasks
appear to be unrelated. The were nonetheless all caused by the very
restrictive safe argument, of which Firejail supersedes.

Two related patches I5a0579b0e and I011db0e9a will enable Firejail in
Wikimedia wikis. This should not be merged until the two other patches
have come through.

Bug: T172582
Bug: T171372
Bug: T161293
Bug: T60526
Bug: T54883
Change-Id: I926fbe6b31b7ef95a0994c6a460972e46a07b4ae

Details

Committed
Ebe123Aug 18 2017, 7:02 AM
Parents
rESCR656169ace447: Merge "Update documentation"
Branches
Unknown
Tags
Unknown
References
refs/changes/06/370306/8
ChangeId
I926fbe6b31b7ef95a0994c6a460972e46a07b4ae