HomePhabricator

Do not extend GeSHi class with private modifications

Authored by TheDJ on May 10 2017, 1:32 PM.

Description

Do not extend GeSHi class with private modifications

Our GeSHi class is intended for other extensions making use of GeSHi.
However other libraries or extensions can bring their own GeSHi to the
classloader. In those cases, we cannot find our private modifications
like $compatibleLexers on this class. Instead use
SyntaxHighlightGeSHiCompat for our privact modifications and keep GeSHi
closer to the original implementation.

Bug: T139594
Change-Id: I5c2ba9dfb08ec31f6b5cfd90083cbae0ae0ac3c4
(cherry picked from commit 1ce9975e18c6ed3e4358cea2e646684123ac78bf)

Details

Committed
TheDJMay 12 2017, 7:49 AM
Parents
rESHG2d5a60a89fb3: SECURITY: Escape start argument before passing to pygments
Branches
Unknown
Tags
Unknown
References
REL1_28
ChangeId
I5c2ba9dfb08ec31f6b5cfd90083cbae0ae0ac3c4