HomePhabricator

Sniff: Enable 2 MediaWiki.Usage.* sniffs

Authored by SamanthaNguyen on Apr 15 2018, 7:20 PM.

Description

Sniff: Enable 2 MediaWiki.Usage.* sniffs

This enables the following 2 related sniffs (by manually fixing):

  • MediaWiki.Usage.ForbiddenFunctions.is_writeable Switched a PHP function call in UserGifts and SystemGifts from is_writeable() to is_writable().
  • MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals Replaced the $_POST superglobal with the WebRequest object via WebRequest#getVal().

Change-Id: I26f58cfced887cca91f18a8ce224dcc2408866df

Details