HomePhabricator

Add instrumentation for edit schema

Description

Add instrumentation for edit schema

Move ve.track() subscriber to its own file, and have it
route mwtiming.* events (for TimingData) and mwedit.* events
(for Edit schema) differently. Most of the data population
lives in the subscriber, so actual ve.track() calls are
pretty lightweight.

Existing ve.track() calls with timing data were kept with
their names intact for backwards compatibility, but
we may eventually want to throw them out and start from scratch.

ve.init.mw.ViewPageTarget.init.js:

  • Remove old track subscriber
  • Track init and ready events
  • Remove old ve.track( 'Edit', ... ) crap that didn't work

ve.init.mw.ViewPageTarget.js:

  • Fire the saveWorkflowBegin event before the save dialog loads rather than after
  • Remove unnecessary this.events.trackSaveError() calls: TargetEvents already listens to these events itself
  • Remove badtoken handler because all it was was an unnecessary trackSaveError() call
  • Add abort tracking
    • Pass trackMechanism through deactivate() and cancel()

ve.init.mw.Target.js:

  • Add static.integrationType to populate the 'integration' field in the schema

ve.init.mw.TargetEvents.js:

  • Simplify onSaveError* methods away into connect bindings
  • Map track topics to mwtiming.* so they can be routed separately
  • Track save-related mwedit.* events

Depends on I978eda96c in WikimediaEvents

Change-Id: Iae677d9b15c71d2b18e795bd5179d11876c06abd