HomePhabricator

Follow-up 5c38995bd94f: don't destroy toolbar twice

Authored by Catrope.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Follow-up 5c38995bd94f: don't destroy toolbar twice

The toolbar.destroy() call that was added in 5c38995bd94f was
needed to destroy the dummy toolbar when tearing down VE
before a surface had been intialized. But when tearing down
VE after the surface had been initialized (e.g. exiting using
the Read tab), we would do:

  • setTimeout in tearDownToolbar()
    • Set toolbar height to 0 and wait for transitionend
      • toolbar.destroy() once transition complete
  • toolbar.destroy() in cancel()

This meant that we'd listen for a transitionend event
on an unattached element (because once the setTimeout runs,
the toolbar has already been destroyed by the second call),
which of course never fires, so we'd never resolve the
tearDownToolbar deferred and never finish tearing down VE.

Bug: T98388
Change-Id: I504f0cb0bf13643773fc98cb18b7b380cccb2f88
(cherry picked from commit e644d33a8d7c109c4c31c2e07405e319f83ef2c2)

Details

Committed
CatropeMay 6 2015, 11:27 PM
Parents
rEVEDbb9cb35b8822: Creating new wmf/1.26wmf5 branch
Branches
Unknown
Tags
Unknown
ChangeId
I504f0cb0bf13643773fc98cb18b7b380cccb2f88