HomePhabricator

Use the CirrusSearchBuildDocumentParse hook

Authored by Cparle on Nov 7 2018, 4:17 PM.

Description

Use the CirrusSearchBuildDocumentParse hook

Use CirrusSearchBuildDocumentParse instead of
SearchDataForIndex because some of the data in the
latter can be overwritten (in particular
opening_text)

Bug: T208955
Change-Id: I3a2cfef116a997bb341b3559da390fdd0a74c2e1

Event Timeline

daniel added a subscriber: daniel.Nov 9 2018, 12:28 PM
daniel added inline comments.
/src/WikibaseMediaInfoHooks.php
312

Having a singe Content object here means this hook is not MCR aware.
Instead of a Content object and a ParserOutput object, this should take a RenderedRevision object. RenderedRevision provides access to all slot's Content as well as to the ParserOutput of each slot, and the combined ParserOutput.

Oh, this is in MediaInfo. I suppose there is no way to do better here, then. But Cirrus should needs a better hook.