Diffusion extension-WikibaseMediaInfo 4813162f115e

Update patch set 1
4813162f115eUnpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update patch set 1

Patch Set 1: Code-Review+1

(3 comments)

The changed serialization test case cannot work the way it got changed here. I think we could just keep it as it was before, see eg. ItemIdTest where I got that test case from.

Patch-set: 1
Reviewer: Bene <549@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Code-Review=+1

Details

Provenance

Bene	Authored on Mar 8 2016, 12:02 AM
Gerrit Code Review <gerrit@wikimedia.org>	Committed on Mar 8 2016, 12:02 AM

ChangeId

None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEWBI4813162f115e: Update patch set 1 (authored by Bene).Mar 8 2016, 12:02 AM

Commit No Longer Exists

This commit no longer exists in the repository.