HomePhabricator

Update patch set 1
66953155fff0Unpublished

Authored by WMDE-leszek on Mar 22 2017, 7:07 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 1

Patch Set 1:

You're right that testing the actual behaviour of the class would be better here. Thank you for pointing out why this is actually important here.
I've only meant that maybe it is not worth it to couple those tests of MediaInfo to Wikibase just to re-use those few test methods. Maybe it would be better to simply copy and paste here tests that are relevant here.
I am not strongly resistant to using those traits here, though (ie. I am no sure if that would be "quite heavy, complicated, and fragile" coupling).

Patch-set: 1
Reviewer: WMDE-leszek <2626@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Mar 22 2017, 7:07 AM
Parents
rEWBI90b4dc498aba: Update patch set 1
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEWBI66953155fff0: Update patch set 1 (authored by WMDE-leszek).Mar 22 2017, 7:07 AM

Empty Commit

This commit is empty and does not affect any paths.