HomePhabricator

Detach button before it gets deleted

Description

Detach button before it gets deleted

addQualifierButton.$element's parent node gets emptied before we've
gotten a chance to detach it, so the node (the one that listens to
the click event) is gone.

I'll keep the actual object alive, and just conditionally render
the button, so we can detach it whenever we feel like it.

Bug: T216423
Change-Id: I95cd7a4ccf1268dc2fcdb2b1537c1db9f4d5ec0f

Details

Provenance
matthiasmullieAuthored on Feb 18 2019, 5:15 PM
Jdforrester-WMFCommitted on Feb 19 2019, 8:00 AM
Parents
rEWBIe7ad0964ffd5: Localisation updates from https://translatewiki.net.
Branches
Unknown
Tags
Unknown
ChangeId
I95cd7a4ccf1268dc2fcdb2b1537c1db9f4d5ec0f