HomePhabricator

Detach button before it gets deleted
9a12326ae24aUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Detach button before it gets deleted

addQualifierButton.$element's parent node gets emptied before
we've gotten a chance to detaach it, so the node (the one that
listens to the click event) is gone.

I'll keep the actual object alive, and just conditionally
render the button, so we can detach it whenever we feel like it.

Bug: T216423
Change-Id: I95cd7a4ccf1268dc2fcdb2b1537c1db9f4d5ec0f

Details

Provenance
matthiasmullieAuthored on Feb 18 2019, 5:15 PM
ChangeId
I95cd7a4ccf1268dc2fcdb2b1537c1db9f4d5ec0f

Commit No Longer Exists

This commit no longer exists in the repository.