HomePhabricator

Delay rendering of OOUI icons until banner rendering

Description

Delay rendering of OOUI icons until banner rendering

Whereas Mustache templating library calls toString on any objects
passed to it, the API doesn't. This change delays the generation of
OOUI IconWidget until the rendering of the banner itself.

Changes:
A new method expandIconTemplateOptions is now responsible for generating
html for icon and is done at parse time.

Other changes:
In icon definitions remove icon prefix since its unnecessary information
Update tests

Bug: T111304
Change-Id: I7f81678226f9fca48345e31a00a126e34b552675

Details

Provenance
JdlrobsonAuthored on
bd808Committed on Sep 10 2015, 12:36 AM
Parents
rEWDPc8e81042a33e: Creating new wmf/1.26wmf22 branch
Branches
Unknown
Tags
Unknown
References
refs/changes/02/237302/1
ChangeId
I7f81678226f9fca48345e31a00a126e34b552675