HomePhabricator

Variation improvements to the Wikispeech includes/ dir

Authored by D3r1ck01 on Apr 19 2019, 10:30 PM.

Description

Variation improvements to the Wikispeech includes/ dir

Improvements include/touch the following areas;

  • Use list() construct where necessary.
  • Remove outdated PHPDocs and/or fix to match recent code.
  • Replace expensive array_push() with $array[] = $xzy construct.
  • Fix glue position in implode() method, though PHP can take any other (glue, pieces or pieces, glue), to keep consistency with explode(), let the glue come before the pieces.

I think it's my first patch into the repo, more coming!

Change-Id: Ia4692f01a21ce8c75a0b781f7c18c510230dbce5

Details