HomePhabricator

Make Form extend EntityDocument
21e33d4fe489Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Make Form extend EntityDocument

I intentionally leave two unfinished decisions in this patch:

  1. Form::setId is short-circuited with an exception. I'm aware this is

awkward, but I believe this is the best we can do for now.

  1. I believe lists of grammatical features should also be equal if the

order is different. But this heavily depends on an other decision: is the
first grammatical feature somehow "special", e.g. in certain formatters?
The order might be relevant then. For this patch here I go with the basic
solution and consider different orders different.

Bug: T180469
Change-Id: Ib6a7ca4b0e42b3fc1535a20eb48976aeb1abaf8f

Details

Provenance
thiemowmdeAuthored on Nov 17 2017, 11:54 AM
ChangeId
Ib6a7ca4b0e42b3fc1535a20eb48976aeb1abaf8f

Commit No Longer Exists

This commit no longer exists in the repository.