HomePhabricator

Minimize jump on Special:NewLexeme when lemma language field is hidden.
2cbcb65934aeUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Minimize jump on Special:NewLexeme when lemma language field is hidden.

With JS enabled the lemma language field is only shown if the language
cannot be derived from the lexeme language. Since the field needs to be
visible for users with JS disabled, it is hidden via JS on page load.

The "jump" occurs due to the field being visible while ResourceLoader is
pulling in dependencies and then disappears once everything is loaded.
This patch takes the naive approach of avoiding ResourceLoader by
inlining the part of the script that hides the field, thereby
minimizing the jump.

Bug: T165151
Change-Id: Ia3b0107d3c52b258c103db6b06aad809cfe1e2ab

Details

Provenance
Jakob_WMDEAuthored on Mar 2 2018, 4:04 PM
ChangeId
Ia3b0107d3c52b258c103db6b06aad809cfe1e2ab

Commit No Longer Exists

This commit no longer exists in the repository.