Diffusion extension-WikibaseLexeme 5e79f1845088

Form statement GUIDs: generate on clone
5e79f1845088
Actions

Authored by Pablo-WMDE on Oct 1 2018, 11:06 AM.

Description

Form statement GUIDs: generate on clone

Statement GUIDs depend on the id of the entity the statment belongs to.
With the change of when forms are added to lexemes and hence their id is
known, we no longer need to defer the update of the form statement GUIDs

Bug: T194732
Change-Id: Ia724b7601235e942abb8340f1c0762e7c23312b1

Details

Committed

Pablo-WMDE

Oct 1 2018, 2:13 PM

Parents

rEWLEf88518f72056: Form: id must be FormId

Branches

Unknown

Tags

Unknown

References

refs/changes/27/463727/4

Reverted By

rEWLEc3c5ab8c1f61: Revert "Form statement GUIDs: generate on clone"
rEWLE6322e12ecff7: Revert "Form statement GUIDs: generate on clone"
rEWLEe35ce3fb0567: Revert "Form statement GUIDs: generate on clone"
rEWLE2e12501b1bef: Revert "Form statement GUIDs: generate on clone"

ChangeId

Ia724b7601235e942abb8340f1c0762e7c23312b1

Event Timeline

Pablo-WMDE committed rEWLE5e79f1845088: Form statement GUIDs: generate on clone (authored by Pablo-WMDE).Oct 1 2018, 2:13 PM

Jakob_WMDE mentioned this in rEWLEd65779723128: Revert statement creation of new Forms through the API.Oct 2 2018, 4:42 PM

Jakob_WMDE added a reverting change: rEWLE2e12501b1bef: Revert "Form statement GUIDs: generate on clone".Oct 2 2018, 4:54 PM

Tarrow added a reverting change: rEWLEe35ce3fb0567: Revert "Form statement GUIDs: generate on clone".Oct 2 2018, 5:24 PM

Jakob_WMDE added a reverting change: rEWLE6322e12ecff7: Revert "Form statement GUIDs: generate on clone".Oct 2 2018, 5:28 PM

• Addshore added a reverting change: rEWLEc3c5ab8c1f61: Revert "Form statement GUIDs: generate on clone".Oct 2 2018, 5:38 PM

Changes (8)

				Path
	M			src/Api/AddFormRequest.php
	M			src/ChangeOp/ChangeOpFormAdd.php
	M			src/ChangeOp/ChangeOpFormClone.php
	M			src/ChangeOp/Deserialization/FormListChangeOpDeserializer.php
	M			src/Merge/LexemeFormsMerger.php
	M			tests/phpunit/mediawiki/Api/AddFormRequestParserTest.php
	M			tests/phpunit/mediawiki/ChangeOp/ChangeOpFormAddTest.php
	M			tests/phpunit/mediawiki/ChangeOp/ChangeOpFormCloneTest.php