Diffusion extension-WikibaseLexeme 8cd49782d7eb

Use LexemeIdHtmlFormatter if format is 'text/html; disposition=diff'
8cd49782d7ebUnpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Use LexemeIdHtmlFormatter if format is 'text/html; disposition=diff'

The formatter-factory-callback was using the default EntityIdFormatter
when not of SnakFormatter::FORMAT_HTML_VERBOSE or FORMAT_HTML instead
of the nice LexemeIdHtmlFormatter.

We should also use the LexemeIdHtmlFormatter when FORMAT_HTML_DIFF

Add test to LexemeDiffVisualizerIntegrationTest.php

Bug: T195511
Change-Id: I36f31f6440715b62aefdc26a504f5cb1c4f0e1d9

Details

Provenance

Tarrow

Authored on Jun 6 2018, 1:00 PM

ChangeId

I36f31f6440715b62aefdc26a504f5cb1c4f0e1d9

Event Timeline

Tarrow committed rEWLE8cd49782d7eb: Use LexemeIdHtmlFormatter if format is 'text/html; disposition=diff' (authored by Tarrow).Jun 7 2018, 10:34 AM

Tarrow mentioned this in rEWLEf952732ac6b1: Create patch set 2.Jun 9 2018, 11:39 AM

Commit No Longer Exists

This commit no longer exists in the repository.