HomePhabricator

Relax Lexeme deserialization to not fail with $nextFormId = 1
98aa39e2ffe9Unpublished

Authored by thiemowmde on Oct 12 2017, 7:49 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Relax Lexeme deserialization to not fail with $nextFormId = 1

With the default set to 1 this was guaranteed to fail. See
http://wikidata-lexeme.wmflabs.org/index.php/Lexeme:L25
for an example why this is relevant. We might make this more strict
later, but for now we figured it helps to relax this.

Also, if the nextFormId field is not given, but forms are given, why
should the code always fail in such a situation?

Bug: T164742
Change-Id: If2e4afe80a977ef5cdbbe4e68f329ef7191a3e62

Details

Committed
thiemowmdeOct 12 2017, 9:42 AM
Parents
rEWLEe577eac2a88a: Make Lexeme constructor accept FormSet only
Branches
Unknown
Tags
Unknown
References
refs/changes/90/383790/3
ChangeId
If2e4afe80a977ef5cdbbe4e68f329ef7191a3e62