HomePhabricator

Form representations: languages as key
a44964be5579Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Form representations: languages as key

Languages are used as keys of form representations (ever since T190928 /
I054e894d8f1c8b564389c45ba285edef558d6c74), RequestParsers'
validateRepresentationLanguage() method enforces that key and language
are consistent. A situation in which language info in consistent but two
items with the same key exist can be logically ruled out.
There is a vague chance that we receive a malformed JSON payload that
contains a "map" with the same language key twice (not organically
producable by a client) - in that case the last one will prevail;
which feels acceptable IMHO and would require massive overhead to
address.

Change-Id: Ib6f726d6a1b1bb0f878d473ca0fae958f34ab7df

Details

Provenance
Pablo-WMDEAuthored on May 3 2018, 4:45 PM
ChangeId
Ib6f726d6a1b1bb0f878d473ca0fae958f34ab7df

Commit No Longer Exists

This commit no longer exists in the repository.