HomePhabricator

Replace custom module loading with a webpack build step
ada84cb8b37cUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Replace custom module loading with a webpack build step

While implementing the vue server-side-rendering spike, we had issues with JS
tooling such as webpack because the module alias system isn't understood. It
also breaks IDE navigation and refactoring and violates the principle of least
surprise. That's little benefit of typgin out relative paths (or having the IDE
do it for you).

This comes with the downside of a build step, but we need that anyway to adopt
current JS language features without losing browser compatibility. It will also
allow to enable advanced developer features like hot reloading.

For now we would probably need to commit the result of the build to the
repository, although I'd prefer the build to be run on Jenkins and the result
stored in a artifact repository instead since this will create big diffs and is
manual overhead.

For now, build the file manually using npm run build.

Change-Id: I7454ed84b9f6be99fd8cf1a878fc7e02f8cbd07a

Details

Provenance
christophneurothAuthored on Sep 25 2017, 2:26 PM
ChangeId
I7454ed84b9f6be99fd8cf1a878fc7e02f8cbd07a

Commit No Longer Exists

This commit no longer exists in the repository.