HomePhabricator

Replace jasmine expect and custom finders with unexpected-dom
b20de73a5751Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Replace jasmine expect and custom finders with unexpected-dom

unexpected-dom

  • already solves most of our custom use cases
  • has (arguably) better readability at the cost of string-y API
  • allows to compose assertions
  • provides great error messages when tests fail
  • decouples assertions from the surrounding test runner

Change-Id: I5cd3e30b1461fb46b4a159c111e08005d956ee78

Details

Provenance
christophneurothAuthored on Jul 25 2017, 4:28 PM
ChangeId
I5cd3e30b1461fb46b4a159c111e08005d956ee78

Commit No Longer Exists

This commit no longer exists in the repository.