HomePhabricator

Update patch set 7
cc1347a1e49cUnpublished

Authored by Aleksey_WMDE on Jan 3 2017, 4:00 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 7

Patch Set 7:

Looks good to me now.

> As we've decided to remove the "get arguments from subpage" from
> the production class, these tests don't cover this at all, if I see
> correctly. This is good. But as this functionality is still in the
> production class, it would be nice to either have a patch removing
> unwanted functionality, or create a ticket about removing this
> functionality, so this does not stay in production code, untested.

> Looks good to me now.
> As we've decided to remove the "get arguments from subpage" from
> the production class, these tests don't cover this at all, if I see
> correctly. This is good. But as this functionality is still in the
> production class, it would be nice to either have a patch removing
> unwanted functionality, or create a ticket about removing this
> functionality, so this does not stay in production code, untested.

Already removed in I2d0ee034ae8ccb6af26ab287de443d6189057d4b

Patch-set: 7
Reviewer: Aleksey Bekh-Ivanov (WMDE) <4089@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Jan 3 2017, 4:00 PM
Parents
rEWLE4005a8194ea7: Update patch set 7
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEWLEcc1347a1e49c: Update patch set 7 (authored by Aleksey_WMDE).Jan 3 2017, 4:00 PM

Empty Commit

This commit is empty and does not affect any paths.