HomePhabricator

Remove subclassing and unused code from LexemeTemplateFactory

Authored by thiemowmde on Apr 10 2017, 9:50 AM.

Description

Remove subclassing and unused code from LexemeTemplateFactory

See discussion at Ie743670. This patch removes the subclassing that was
there for code reuse only. I strongly believe that the amount of reused
code just does not justify the disadvantages this approach comes with:
This introduces a ton of unused code, and blocks us from doing more
trivial refactorings on the base class.

This patch also turns both TemplateRegistry as well as Template classes
into private implementation details.

This patch also makes all tests independent from the actual templates.php
file.

Bug: T161789
Change-Id: I745a53ad077d0cc5e482ed4eaf19597682393bef

Details