HomePhabricator

Introduce and use NoCrossReferencingLexemeStatements
f1e81a94afc5Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Introduce and use NoCrossReferencingLexemeStatements

The previous implementation of merge validation would not
catch references between the two different types of sub entity
(form and sense).

This new attempt has come from discussion on and about Iaf0582870
which was created to add Sense support for merging Lexeme entities.
The new approach brings the validation up to the Lexeme level
rather than doing it per sub entity type used during the merge.

T198106 is the origional ticket with the origional BDD for this
decision. It has also been double checked with Lydia and the folks that
worked on NoCrossReferencingFormStatements that I am removing here.

This patch also introduced LexemeStatementEntityReferenceExtractor.

Bug: T203454
Bug: T198106
Change-Id: Ie56adf738cb8cf6f5013ff99da9b69fad4ddf9d5

Details

Provenance
AddshoreAuthored on Sep 5 2018, 3:22 PM
Lucas_Werkmeister_WMDECommitted on Sep 10 2018, 11:11 AM
ChangeId
Ie56adf738cb8cf6f5013ff99da9b69fad4ddf9d5

Commit No Longer Exists

This commit no longer exists in the repository.