HomePhabricator

Respond to second code review by Reedy
35ec0a1398d2Unpublished

Authored by Sophivorus on Dec 23 2017, 6:45 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Respond to second code review by Reedy

  • Remove URL parsing, per unnecessary and potential trouble-maker
  • Remove "title" parameter, per unnecessary
  • getWikipediaTitle() was no longer necessary
  • Fix some errors in the error handler
  • Rename $wikipediaTitle to $title

Bug: T149766
Change-Id: I1d0d44a81d625033f0fbd418409b9a0fef162885

Details