HomePhabricator

Requested fixes
4fb84f60c765Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Requested fixes

  • Break code into smaller methods
  • Add error handling
  • Build <span> with Html::rawElement
  • Short array syntax
  • Remove <small> from wikipediaextracts-credits
  • Add Parser typehint
  • Remove extract()
  • API requests to formatversion=2
  • Add user agent to API requests
  • Validate language codes
  • Remove <WikipediaExtract> tag and duplicate code
  • Declare public and private variables and methods
  • Add wgWikipediaExtractsAddCredits config variable
  • Add \n to EOF

Bug: T149766
Change-Id: I1c1296c0381000c75ddfa2577bf5588343abdf72

Details

Provenance
SophivorusAuthored on Nov 4 2016, 4:09 AM
Parents
rEWPE1c671aad2edb: Localisation updates from https://translatewiki.net.
Branches
Unknown
Tags
Unknown
References
refs/changes/86/319786/2
ChangeId
I1c1296c0381000c75ddfa2577bf5588343abdf72