HomePhabricator

Update patch set 1
252e498f2914Unpublished

Authored by KMuthu on Mar 22 2017, 12:53 AM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 1

Patch Set 1:

Looks good otherwise. Did you find in your testing that you didn't

> need the commented-out onEchoGetDefaultNotifiedUsers code to get
> the notification to work?

Yes, It did not require onEchoGetDefaultNotifiedUsers to get the notification triggered. Notification worked fine without onEchoGetDefaultNotifiedUsers .

Patch-set: 1
Reviewer: Kmuthu <3878@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Verified=0

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Mar 22 2017, 12:53 AM
Parents
rEWPL9116206bc40c: Update patch set 1
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rEWPL252e498f2914: Update patch set 1 (authored by KMuthu).Mar 22 2017, 12:53 AM

Empty Commit

This commit is empty and does not affect any paths.