HomePhabricator

Quote CLI arguments in `RunsConfig` instructions

Description

Quote CLI arguments in RunsConfig instructions

Summary:
Refactored build instructions in RunsConfig to properly quote command
arguments injected from user data.

Established unit tests for RunsConfig instruction phases.

Refs T170285. Depends on D711

Omit ENV instruction when runs.environment is empty

Fixes T170285

Test Plan:
Run arc unit. Create a config without runs.environment defined and verify
that no bare ENV line ends up in the Dockerfile output.

Reviewers: thcipriani, hashar, mmodell, Release-Engineering-Team

Reviewed By: thcipriani, Release-Engineering-Team

Tags: Release-Engineering-Team

Maniphest Tasks: T170285

Differential Revision: https://phabricator.wikimedia.org/D715

Details

Provenance
dduvallAuthored on Jul 12 2017, 6:54 PM
Reviewer
Release-Engineering-Team
Differential Revision
D715: Quote CLI arguments in `RunsConfig` instructions
Parents
rGBLBR19b47a273717: Broaden base test coverage
Branches
Unknown
Tags
Unknown
Tasks
T170285: blubber: produces empy ENV statements
ChangeId
None