HomePhabricator

Recursive variant expansion

Description

Recursive variant expansion

Summary:
Problem running blubber cfg.yml test with this config:

base: nodejs-slim
variants:
  build:
    base: nodejs-devel
  development:
    includes: [build]
    entrypoint: [npm, start]
  test:
    includes: [development]
    entrypoint: [npm, test]

yields a Dockerfile with FROM nodejs-slim; however, I expected that
the base would be nodejs-devel since test inherits from
development which inherits from build.

In order for this to work as expected we have to recursively expand
variants as in this patch.

Reviewers: dduvall, Release-Engineering-Team

Reviewed By: dduvall, Release-Engineering-Team

Tags: Release-Engineering-Team

Differential Revision: https://phabricator.wikimedia.org/D773

Details

Provenance
thciprianiAuthored on Sep 8 2017, 4:37 PM
Reviewer
Release-Engineering-Team
Differential Revision
D773: Recursive variant expansion
Parents
rGBLBRb25e7c6b661c: Add shared lib node module bins to PATH
Branches
Unknown
Tags
Unknown
ChangeId
None