HomePhabricator

Fix online reindexing for plugins-dependent rules

Authored by Luca Milanesio <luca.milanesio@gmail.com> on Jun 9 2017, 11:41 PM.

Description

Fix online reindexing for plugins-dependent rules

Online reindex recalculates the status of all the changes
by invoking the Prolog rules associated.
That is good in general but breaks systematically when the
rules depend on plugins for their accurate evaluation.

Noteworthy example is the use of singleusergroup plugin in
conjunction with user-specific ACLs for labels.
Another even more severe example is the use of custom
Prolog predicates in rules.pl provided by the owners' plugin.

By swapping the order of registration of the Plugins module
and the Lucene Index module, the lifecycle listener will then
load first the plugins and only afterward activate the online
reindexer.

Bug: Issue 6472
Change-Id: I87da6ac632d08aa915a57a01435cfa415b7de2f9

Event Timeline

Luca Milanesio <luca.milanesio@gmail.com> committed rGERRITDEPLOY86a1dd735cbd: Fix online reindexing for plugins-dependent rules (authored by Luca Milanesio <luca.milanesio@gmail.com>).Jun 12 2017, 10:46 AM