HomePhabricator

Bazel: Fix more buildifier warnings

Authored by David Ostrovsky <david@ostrovsky.org> on Nov 25 2018, 4:28 AM.

Description

Bazel: Fix more buildifier warnings

This fixes buildifier warnings that were not fixed in automatic
mode:

$ find . \( -name BUILD -o -name "*.bzl" \) -print \
    | xargs buildifier --lint=warn
  • Remove unused variables
  • Pattern src/test/java/com/google/gerrit/server/project/Util.java has no wildcard ('*')
  • All calls to rules or macros should pass arguments by keyword (arg_name=value) syntax
  • ctx.new_file is deprecated, used ctx.actions.declare_file instead

Change-Id: I1f8a04e8d576ab637ba8a46118720218ec486fff

Event Timeline

David Pursehouse <dpursehouse@collab.net> committed rGERRITDEPLOYaeaa73e68cef: Bazel: Fix more buildifier warnings (authored by David Ostrovsky <david@ostrovsky.org>).Jan 9 2019, 12:30 PM