HomePhabricator

MediaWiki theme: Make PHP DropdownInputWidget look closer to JS version

Description

MediaWiki theme: Make PHP DropdownInputWidget look closer to JS version

  • Explicitly set height for JS DropdownWidget to match the height of PHP DropdownWidget (which uses a <select>) and other widgets.

    We expected to get 2.275em as 2*0.5+1.275 (2*padding+label), but the widget also has a border, which added 2*1px to the height. 'box-sizing: border-box' doesn't help if you don't actually set the desired height.
  • Match 'border-radius' (although it is hardly visible).
  • Add 'padding-left' to match JS label's 'margin-left'.
  • Add 'vertical-align: middle', just in case.

Bug: T113492
Change-Id: Ieabb382f8ec4b65ea08331e59e424b73bf9fe597

Details

Provenance
matmarexAuthored on
Parents
rGOJUc9d3a041325c: Tag v0.12.10
Branches
Unknown
Tags
Unknown
ChangeId
Ieabb382f8ec4b65ea08331e59e424b73bf9fe597