HomePhabricator

Make the decodeURI / decodeURIComponent distinction more apparent

Authored by Arlolra on Apr 6 2018, 6:54 PM.

Description

Make the decodeURI / decodeURIComponent distinction more apparent

Util.decodeURI was introduced in 2efcd3c using decodeURI. In 84f0dd0,
it was confusingly changed to use decodeURIComponent for its liberal
decoding, despite the possible confusion.

In 3c5334f, decodeURI was explicitly used for its more restricted
abilities but was erroneous replaced in 2f1cda9 w/ Util.decodeURI,
likely because of the failed distinction.

Here we introduce both wrappers, and try to use them where appropriate.

Change-Id: Ib5a03175317e108dfd0e50be00d48d46c82acc1b

Details

Committed
ArlolraApr 6 2018, 9:58 PM
Parents
rGPARd40afe434014: Prevent crashing on foundationwiki pages
Branches
Unknown
Tags
Unknown
References
refs/changes/50/424650/3
ChangeId
Ib5a03175317e108dfd0e50be00d48d46c82acc1b