Diffusion VisualEditor 2cbe96b4b0ec

Make ve.SelectionState#flip return an actual SelectionState
2cbe96b4b0ec
Actions

Tags

None

Subscribers

None

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Make ve.SelectionState#flip return an actual SelectionState

Rather than returning a plain object that looks a lot like
a SelectionState but doesn't have any methods.

This caused a JS error in a Firefox-specific code path
in ve.ce.Surface#showSelectionState.

Bug: T106270
Change-Id: I0e140908b6628b73d630816a67bb0f89c413796d

Details

Provenance

Catrope	Authored on
Jdforrester-WMF	Committed on Jul 21 2015, 7:46 PM

ChangeId

I0e140908b6628b73d630816a67bb0f89c413796d

Event Timeline

Jdforrester-WMF committed rGVED2cbe96b4b0ec: Make ve.SelectionState#flip return an actual SelectionState (authored by Catrope).Jul 21 2015, 7:46 PM

gerritbot mentioned this in T106270: Link editor can't be closed.Jul 21 2015, 8:16 PM

Jdforrester-WMF mentioned this in rEVED16d7165176cf: Update VE core submodule to wmf/1.26wmf15 HEAD (2cbe96b).Jul 21 2015, 11:05 PM

Jdforrester-WMF mentioned this in T140285: Prune old (unused) git branches from VE-core.Jul 13 2016, 6:33 PM

Commit No Longer Exists

This commit no longer exists in the repository.