HomePhabricator

Update patch set 2
5586c59fecd2Unpublished

Authored by XZise on Aug 19 2017, 7:59 PM.

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 2

Patch Set 2: Code-Review+1

In theory looks good, but I'm wondering if in the future it should run on the "commit-msg" hook instead. But it would need some rewrite to parse a file. And with that hook, the HEAD might not point to the state the commit message references to and maybe future changes need to know something the commit message references to.

Patch-set: 2
Reviewer: XZise <1838@e9e9afe9-4712-486d-8885-f54b72dd1951>
Label: Code-Review=+1

Details

Committed
Gerrit Code Review <gerrit@wikimedia.org>Aug 19 2017, 7:59 PM
Parents
rICMV86601e46cb9a: Update patch set 2
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rICMV5586c59fecd2: Update patch set 2 (authored by XZise).Aug 19 2017, 7:59 PM

Empty Commit

This commit is empty and does not affect any paths.